Fix URI encoding #1539
Merged
Fix URI encoding #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to HTTP spec keys should be encoded slightly differently to values.
|
Thanks @johnf for your work here. I understand what you're saying - and it doesn't seem like your commit broke any tests judging from Travis. I would be curious if you could figure out the serialize tests, and what the issue is with them not working? |
|
@niftylettuce if you check the Makefile it looks like all the tests inside clients are only run in the browser |
|
released to npm as v5.2.1 |
This was referenced Apr 4, 2020
This was referenced Jul 16, 2024
This was referenced Jul 24, 2024
This was referenced Aug 2, 2024
This was referenced Sep 6, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having issues with an oData (https://www.odata.org/) based API. oData uses queries like
http://example.com/todo?$skip=100&$top=50
Superagent will currently encode this to http://example.com/todo?%24skip=100&%24top=50
According to HTTP spec this isn't technically correct. While values of query parameters should have fill encoding applied, the list of reserved characters is smaller for the overall URL.
A correct implementation would be to use encodeURIComponent over the query values and then encodeURI over the entire URL. However, the approach I've taken is equivalent.
Some of the answers to https://stackoverflow.com/questions/4540753/should-i-use-encodeuri-or-encodeuricomponent-for-encoding-urls provide some more explanation. I can provide full detail from HTTP and HTML specs if required.
I tried adding a test but the serialize tests seem to be broken. I could only get them to run if I set NODETESTS=tests/client/serialize.js